-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: replace Call
with CallWithRecover
in the close of hash join v1 (#61868)
#62341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: replace Call
with CallWithRecover
in the close of hash join v1 (#61868)
#62341
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@xzhangxian1008 This PR has conflicts, I have hold it. |
/retest |
1 similar comment
/retest |
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #62341 +/- ##
================================================
Coverage ? 71.3134%
================================================
Files ? 1469
Lines ? 425488
Branches ? 0
================================================
Hits ? 303430
Misses ? 101510
Partials ? 20548
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, xzhangxian1008 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/unhold |
This is an automated cherry-pick of #61868
What problem does this PR solve?
Issue Number: close #60926
Problem Summary:
What changed and how does it work?
We introduce a new function
CallWithRecover
to recover the panic in the close of hash join v1Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.