-
Notifications
You must be signed in to change notification settings - Fork 6k
release-8.1: Fix prefetch buffer and GCS EOF retry (#59496, #59851) #62060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-8.1: Fix prefetch buffer and GCS EOF retry (#59496, #59851) #62060
Conversation
Hi @GMHDBJD. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #62060 +/- ##
================================================
Coverage ? 71.2240%
================================================
Files ? 1469
Lines ? 424455
Branches ? 0
================================================
Hits ? 302314
Misses ? 101587
Partials ? 20554
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR manually cherry-picks two PRs to
release-8.1
to resolve a dependency.cherry-pick #59496
cherry-pick #59851
What problem does this PR solve?
Issue Number: close #59495, close #59754
Problem Summary:
This PR addresses two separate but related issues:
net/http
library can causeio.EOF
errors when using GCS, which were not being retried, causing operations to fail.What changed and how does it work?
io.ReadFull
to ensure the prefetch buffer is always filled completely.io.EOF
errors, making the connection more resilient to the underlying library bug.Check List
Tests
Release note