Skip to content

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Mar 1, 2025

What problem does this PR solve?

Issue Number: close #59754

Problem Summary:

What changed and how does it work?

see googleapis/google-cloud-go#7090 and golang/go#53472, it seems a bug of golang net/http. we workaround it

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 1, 2025
Copy link

tiprow bot commented Mar 1, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 1, 2025
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Mar 1, 2025

/cherry-pick feature/release-8.1-gsort-test

@ti-chi-bot
Copy link
Member

@D3Hunter: once the present PR merges, I will cherry-pick it on top of feature/release-8.1-gsort-test in the new PR and assign it to you.

In response to this:

/cherry-pick feature/release-8.1-gsort-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Mar 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, CbcWestwolf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2025
Copy link

ti-chi-bot bot commented Mar 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-01 04:50:56.217546792 +0000 UTC m=+71569.346466531: ☑️ agreed by CbcWestwolf.
  • 2025-03-01 04:57:37.632953273 +0000 UTC m=+71970.761873017: ☑️ agreed by Benjamin2037.

Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8668%. Comparing base (dfc9324) to head (a2a4c4a).
Report is 695 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59851        +/-   ##
================================================
+ Coverage   72.9368%   74.8668%   +1.9300%     
================================================
  Files          1699       1745        +46     
  Lines        469594     477736      +8142     
================================================
+ Hits         342507     357666     +15159     
+ Misses       105979      97493      -8486     
- Partials      21108      22577      +1469     
Flag Coverage Δ
integration 48.6953% <0.0000%> (?)
unit 72.4714% <100.0000%> (+0.0344%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 62.6264% <100.0000%> (+16.2969%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CbcWestwolf
Copy link
Member

/retest

Copy link

tiprow bot commented Mar 1, 2025

@D3Hunter: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow a2a4c4a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit ec18512 into pingcap:master Mar 1, 2025
30 of 31 checks passed
@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch feature/release-8.1-gsort-test: #59852.

In response to this:

/cherry-pick feature/release-8.1-gsort-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@D3Hunter D3Hunter deleted the gcs-retry branch March 1, 2025 07:12
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 27, 2025

/cherry-pick release-8.1

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 27, 2025

/cherry-pick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 27, 2025
@ti-chi-bot
Copy link
Member

@GMHDBJD: new pull request created to branch release-8.5: #62058.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 27, 2025
@ti-chi-bot
Copy link
Member

@GMHDBJD: new pull request created to branch release-8.1: #62059.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

GMHDBJD pushed a commit to GMHDBJD/tidb that referenced this pull request Jun 27, 2025
GMHDBJD pushed a commit to GMHDBJD/tidb that referenced this pull request Jun 27, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 2, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 2, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #62127.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

should retry on GCS error Get \"https://storage.googleapis.com/storage": EOF
5 participants