Skip to content

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Jun 27, 2025

This PR manually cherry-picks two PRs to release-8.5 to resolve a dependency.


cherry-pick #59496
cherry-pick #59851

What problem does this PR solve?

Issue Number: close #59495, close #59754

Problem Summary:
This PR addresses two separate but related issues:

  1. The prefetch buffer was not always being fully filled, potentially leading to inefficient reads.
  2. A bug in Go's net/http library can cause io.EOF errors when using GCS, which were not being retried, causing operations to fail.

What changed and how does it work?

  1. Prefetch Buffer Fix: Switched to using io.ReadFull to ensure the prefetch buffer is always filled completely.
  2. GCS EOF Retry: Added a workaround in the GCS storage layer to specifically retry on io.EOF errors, making the connection more resilient to the underlying library bug.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2025
Copy link

tiprow bot commented Jun 27, 2025

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@310cdcc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #62061   +/-   ##
================================================
  Coverage               ?   57.8742%           
================================================
  Files                  ?       1771           
  Lines                  ?     633399           
  Branches               ?          0           
================================================
  Hits                   ?     366575           
  Misses                 ?     242298           
  Partials               ?      24526           
Flag Coverage Δ
integration 38.7399% <63.6363%> (?)
unit 72.7735% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 63.2388% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
Copy link

ti-chi-bot bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
Copy link

ti-chi-bot bot commented Jul 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-01 01:12:06.803028728 +0000 UTC m=+1357379.526207709: ☑️ agreed by Benjamin2037.
  • 2025-07-01 02:15:58.67718294 +0000 UTC m=+1361211.400361917: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 2, 2025
@hawkingrei
Copy link
Member

/retest

1 similar comment
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jul 3, 2025

/retest

Copy link

tiprow bot commented Jul 3, 2025

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jul 7, 2025

/retest

Copy link

tiprow bot commented Jul 7, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor

D3Hunter commented Jul 8, 2025

/retest

Copy link

tiprow bot commented Jul 8, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 1207f79 into pingcap:release-8.5 Jul 8, 2025
31 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants