Skip to content

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Sep 2, 2025

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

then we can make the checksum step faster, and don't need user to set it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

import 100G data locally, see it's 60

[2025/09/02 19:29:36.495 +08:00] [INFO] [import.go:1322] ["set import thread count for nextgen kernel"] [keyspaceName=SYSTEM] [table=sys] ["thread count"=4] ["max node count"=1] ["target node cpu count"=10] ["dist sql scan concurrency"=60] ["total file size"=100GiB]

import 100T, it's 281

[2025/09/02 19:42:52.314 +08:00] [INFO] [import.go:1322] ["set import thread count for nextgen kernel"] [keyspaceName=SYSTEM] [table=sys] ["thread count"=10] ["max node count"=25] ["dist sql scan concurrency"=281] ["target node cpu count"=10] ["total file size"=100TiB]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2025
Copy link

tiprow bot commented Sep 2, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title [wip]importinto: calculate distsql scan concurency in nextgen importinto: calculate distsql scan concurency in nextgen Sep 2, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2025
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.2699%. Comparing base (3d9a0eb) to head (b7dd28b).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63341        +/-   ##
================================================
+ Coverage   72.7832%   73.2699%   +0.4866%     
================================================
  Files          1832       1832                
  Lines        495794     496175       +381     
================================================
+ Hits         360855     363547      +2692     
+ Misses       113010     110782      -2228     
+ Partials      21929      21846        -83     
Flag Coverage Δ
integration 42.0275% <0.0000%> (?)
unit 72.3279% <76.9230%> (+0.0759%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5345% <ø> (+0.0025%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 2, 2025

/retest

Copy link

tiprow bot commented Sep 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 2, 2025

/retest

Copy link

tiprow bot commented Sep 2, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 3, 2025

/cherry-pick release-nextgen-20250815

@ti-chi-bot
Copy link
Member

@D3Hunter: once the present PR merges, I will cherry-pick it on top of release-nextgen-20250815 in the new PR and assign it to you.

In response to this:

/cherry-pick release-nextgen-20250815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

ti-chi-bot bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
Copy link

ti-chi-bot bot commented Sep 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-03 04:46:48.935298854 +0000 UTC m=+933900.813129808: ☑️ agreed by GMHDBJD.
  • 2025-09-03 09:18:36.094517873 +0000 UTC m=+950207.972348817: ☑️ agreed by wjhuang2016.

@D3Hunter
Copy link
Contributor Author

D3Hunter commented Sep 3, 2025

/retest

Copy link

tiprow bot commented Sep 3, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 9825dfe into pingcap:master Sep 3, 2025
28 checks passed
@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch release-nextgen-20250815: #63362.

In response to this:

/cherry-pick release-nextgen-20250815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants