Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #63341

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

then we can make the checksum step faster, and don't need user to set it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

import 100G data locally, see it's 60

[2025/09/02 19:29:36.495 +08:00] [INFO] [import.go:1322] ["set import thread count for nextgen kernel"] [keyspaceName=SYSTEM] [table=sys] ["thread count"=4] ["max node count"=1] ["target node cpu count"=10] ["dist sql scan concurrency"=60] ["total file size"=100GiB]

import 100T, it's 281

[2025/09/02 19:42:52.314 +08:00] [INFO] [import.go:1322] ["set import thread count for nextgen kernel"] [keyspaceName=SYSTEM] [table=sys] ["thread count"=10] ["max node count"=25] ["dist sql scan concurrency"=281] ["target node cpu count"=10] ["total file size"=100TiB]
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815 labels Sep 3, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
@D3Hunter
Copy link
Contributor

D3Hunter commented Sep 3, 2025

/retest

Copy link

ti-chi-bot bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2025
Copy link

ti-chi-bot bot commented Sep 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-03 11:55:17.843643817 +0000 UTC m=+8061.826741255: ☑️ agreed by D3Hunter.
  • 2025-09-04 02:14:00.378348886 +0000 UTC m=+59584.361446324: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 1743ca6 into pingcap:release-nextgen-20250815 Sep 4, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-63341-to-release-nextgen-20250815 branch September 4, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants