-
Notifications
You must be signed in to change notification settings - Fork 293
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter. (#12287)
#12288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter. (#12287)
#12288
Conversation
This reverts commit 214881d.
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the DDL (Data Definition Language) filtering capabilities within the ddlPuller
component. It introduces the ability to discard specific DDL operations based on their transaction start timestamp. This new functionality allows users to configure the system to ignore problematic DDLs that might otherwise cause replication errors, such as complex RENAME TABLE
statements. By providing a mechanism to skip these unsupported DDLs, the changefeed can continue replicating data without interruption, improving the overall robustness and resilience of the data synchronization process.
Highlights
- Enhanced DDL Filtering: The
ShouldDiscardDDL
function in the filter package now accepts astartTs
(transaction start timestamp) parameter, enabling more granular control over which DDL operations are discarded. - Integration of Start Timestamp in DDL Puller: The DDL puller now passes the transaction start timestamp to the DDL filter, allowing it to skip specific DDLs that might cause issues, such as complex
RENAME TABLE
operations that TiCDC cannot handle. - New Configuration for Ignoring DDLs: A new configuration option,
ignore-txn-start-ts
, has been introduced. Users can specify a list of transaction start timestamps for DDLs that should be explicitly ignored by the changefeed, providing a mechanism to recover from DDL-related errors. - Improved Test Coverage: New unit tests have been added to verify that DDLs can be successfully discarded based on their transaction start timestamp, ensuring the reliability of the new filtering mechanism.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a mechanism to discard unsupported DDL statements by specifying their transaction start timestamp in the filter configuration. The changes correctly propagate the startTs
to the ShouldDiscardDDL
function and update the filter logic to check against a list of ignored timestamps. The implementation is consistent across the affected components, and the new functionality is well-tested, including a unit test for skipping a RENAME TABLE
DDL that would otherwise fail. The code quality is good, and the changes effectively address the problem of handling DDLs that are not supported by TiCDC. I have no further suggestions for improvement.
Codecov Report❌ Patch coverage is Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #12288 +/- ##
================================================
Coverage ? 55.1188%
================================================
Files ? 1003
Lines ? 136828
Branches ? 0
================================================
Hits ? 75418
Misses ? 55871
Partials ? 5539 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #12287
What problem does this PR solve?
Issue Number: close #12286
What is changed and how it works?
IgnoreTxnStartTs
in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.Check List
Tests
cf.toml
, add theignore-txn-start-ts=[460194169353928710]
to filter.cf.toml
.Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note