Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #12287

What problem does this PR solve?

Issue Number: close #12286

What is changed and how it works?

  1. DDLs can be skipped in the ddlPuller by setting IgnoreTxnStartTs in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. create a changefeed.
  2. execute follow ddl upstream
create table a (a bigint primary key, b int);
create table b like a;
rename table a to c, b to a, c to b;
  1. changefeed meets the following error:
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 460194169340821515,
      "checkpoint": "2025-08-18 15:17:19.441",
      "error": {
        "time": "2025-08-18T15:17:20.493361+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrHandleDDLFailed",
        "message": "[CDC:ErrHandleDDLFailed]handle ddl failed, query: rename table a to c, b to a, c to b, startTs: 460194169353928710. If you want to skip this DDL and continue with replication, you can manually execute this DDL downstream. Afterwards, add `ignore-txn-start-ts=[460194169353928710]` to the changefeed in the filter configuration.: [CDC:ErrSnapshotTableNotFound]table 112 not found in schema snapshot"
  1. Adjust changefeed filter config file cf.toml, add the ignore-txn-start-ts=[460194169353928710] to filter.
[filter]
ignore-txn-start-ts = [460194169353928710]
  1. Update chagnefeed with cf.toml.
./cdc cli changefeed update -c test --config=cf.toml 
  1. resume changefeed, chagnefeed resume to normal.
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "normal",
      "tso": 460194185921429508,
      "checkpoint": "2025-08-18 15:18:22.691",
      "error": null
    }
  }
]

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Support discarding unsupported DDL by setting `ignore-txn-start-ts` in filter.

This reverts commit 214881d.
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 18, 2025
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign july2993 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the DDL (Data Definition Language) filtering capabilities within the ddlPuller component. It introduces the ability to discard specific DDL operations based on their transaction start timestamp. This new functionality allows users to configure the system to ignore problematic DDLs that might otherwise cause replication errors, such as complex RENAME TABLE statements. By providing a mechanism to skip these unsupported DDLs, the changefeed can continue replicating data without interruption, improving the overall robustness and resilience of the data synchronization process.

Highlights

  • Enhanced DDL Filtering: The ShouldDiscardDDL function in the filter package now accepts a startTs (transaction start timestamp) parameter, enabling more granular control over which DDL operations are discarded.
  • Integration of Start Timestamp in DDL Puller: The DDL puller now passes the transaction start timestamp to the DDL filter, allowing it to skip specific DDLs that might cause issues, such as complex RENAME TABLE operations that TiCDC cannot handle.
  • New Configuration for Ignoring DDLs: A new configuration option, ignore-txn-start-ts, has been introduced. Users can specify a list of transaction start timestamps for DDLs that should be explicitly ignored by the changefeed, providing a mechanism to recover from DDL-related errors.
  • Improved Test Coverage: New unit tests have been added to verify that DDLs can be successfully discarded based on their transaction start timestamp, ensuring the reliability of the new filtering mechanism.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to discard unsupported DDL statements by specifying their transaction start timestamp in the filter configuration. The changes correctly propagate the startTs to the ShouldDiscardDDL function and update the filter logic to check against a list of ignored timestamps. The implementation is consistent across the affected components, and the new functionality is well-tested, including a unit test for skipping a RENAME TABLE DDL that would otherwise fail. The code quality is good, and the changes effectively address the problem of handling DDLs that are not supported by TiCDC. I have no further suggestions for improvement.

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5@4d578e9). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.5411% <0.0000%> (?)
dm 50.0519% <0.0000%> (?)
engine 53.2110% <0.0000%> (?)
Flag Coverage Δ
unit 55.1188% <91.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #12288   +/-   ##
================================================
  Coverage               ?   55.1188%           
================================================
  Files                  ?       1003           
  Lines                  ?     136828           
  Branches               ?          0           
================================================
  Hits                   ?      75418           
  Misses                 ?      55871           
  Partials               ?       5539           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants