Skip to content

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #12286

What is changed and how it works?

  1. DDLs can be skipped in the ddlPuller by setting IgnoreTxnStartTs in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. create a changefeed.
  2. execute follow ddl upstream
create table a (a bigint primary key, b int);
create table b like a;
rename table a to c, b to a, c to b;
  1. changefeed meets the following error:
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 460194169340821515,
      "checkpoint": "2025-08-18 15:17:19.441",
      "error": {
        "time": "2025-08-18T15:17:20.493361+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrHandleDDLFailed",
        "message": "[CDC:ErrHandleDDLFailed]handle ddl failed, query: rename table a to c, b to a, c to b, startTs: 460194169353928710. If you want to skip this DDL and continue with replication, you can manually execute this DDL downstream. Afterwards, add `ignore-txn-start-ts=[460194169353928710]` to the changefeed in the filter configuration.: [CDC:ErrSnapshotTableNotFound]table 112 not found in schema snapshot"
  1. Adjust changefeed filter config file cf.toml, add the ignore-txn-start-ts=[460194169353928710] to filter.
[filter]
ignore-txn-start-ts = [460194169353928710]
  1. Update chagnefeed with cf.toml.
./cdc cli changefeed update -c test --config=cf.toml 
  1. resume changefeed, chagnefeed resume to normal.
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "normal",
      "tso": 460194185921429508,
      "checkpoint": "2025-08-18 15:18:22.691",
      "error": null
    }
  }
]

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Support discarding unsupported DDL by setting `ignore-txn-start-ts` in filter.

@asddongmen asddongmen self-assigned this Aug 18, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @asddongmen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

The pull request introduces a new filtering mechanism in TiCDC's ddlPuller component. This enhancement allows users to explicitly skip or discard specific DDL (Data Definition Language) operations that might be unsupported or cause issues during replication, by configuring a list of transaction start timestamps (ignore-txn-start-ts). This provides greater control and resilience for changefeeds encountering problematic DDLs.

Highlights

  • Configurable DDL Discarding: Implemented a new ignore-txn-start-ts configuration option within the filter, enabling the ddlPuller to skip DDLs based on their transaction start timestamp.
  • Enhanced ShouldDiscardDDL Functionality: The ShouldDiscardDDL function now accepts the DDL's transaction start timestamp, allowing for more granular control over which DDLs are discarded.
  • Improved DDL Handling Logic: Updated the ddlPuller's internal logic, particularly for complex DDLs like RENAME TABLE, to properly utilize the new ignore-txn-start-ts filter when determining whether to discard a DDL.
  • Comprehensive Test Coverage: Added new unit tests to validate the correct behavior of the ddlPuller and the filter, ensuring that DDLs are discarded as expected when ignore-txn-start-ts is configured.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a useful feature to skip problematic DDLs using ignore-txn-start-ts. The changes to the filter interface and its usage across the ddl_puller are mostly correct. I've identified a bug where CREATE TABLES DDLs cannot be skipped by startTs and a leftover debug log message that should be removed. The tests for the new functionality are well-written.

Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 18, 2025
Signed-off-by: dongmen <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2025
Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-18 07:35:22.566759978 +0000 UTC m=+252530.509935484: ☑️ agreed by lidezhu.
  • 2025-08-18 09:07:08.87383628 +0000 UTC m=+258036.817011786: ☑️ agreed by 3AceShowHand.

@asddongmen
Copy link
Contributor Author

/test pull-dm-integration-test

@asddongmen asddongmen added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 18, 2025
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Aug 18, 2025
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/test pull-cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit db43be2 into pingcap:master Aug 18, 2025
26 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #12288.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #12289.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #12290.
But this PR has conflicts, please resolve them!

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #12291.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rename tables DDL cause changefeed failed cannot be fixed by the ignore-txn-start-ts
4 participants