-
Notifications
You must be signed in to change notification settings - Fork 293
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter.
#12287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter.
#12287
Conversation
This reverts commit 214881d.
Signed-off-by: dongmen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @asddongmen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
The pull request introduces a new filtering mechanism in TiCDC's ddlPuller component. This enhancement allows users to explicitly skip or discard specific DDL (Data Definition Language) operations that might be unsupported or cause issues during replication, by configuring a list of transaction start timestamps (ignore-txn-start-ts). This provides greater control and resilience for changefeeds encountering problematic DDLs.
Highlights
- Configurable DDL Discarding: Implemented a new ignore-txn-start-ts configuration option within the filter, enabling the ddlPuller to skip DDLs based on their transaction start timestamp.
- Enhanced ShouldDiscardDDL Functionality: The ShouldDiscardDDL function now accepts the DDL's transaction start timestamp, allowing for more granular control over which DDLs are discarded.
- Improved DDL Handling Logic: Updated the ddlPuller's internal logic, particularly for complex DDLs like RENAME TABLE, to properly utilize the new ignore-txn-start-ts filter when determining whether to discard a DDL.
- Comprehensive Test Coverage: Added new unit tests to validate the correct behavior of the ddlPuller and the filter, ensuring that DDLs are discarded as expected when ignore-txn-start-ts is configured.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a useful feature to skip problematic DDLs using ignore-txn-start-ts
. The changes to the filter interface and its usage across the ddl_puller
are mostly correct. I've identified a bug where CREATE TABLES
DDLs cannot be skipped by startTs
and a leftover debug log message that should be removed. The tests for the new functionality are well-written.
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, lidezhu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test pull-dm-integration-test |
/retest |
/test pull-cdc-integration-kafka-test |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #12286
What is changed and how it works?
IgnoreTxnStartTs
in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.Check List
Tests
cf.toml
, add theignore-txn-start-ts=[460194169353928710]
to filter.cf.toml
.Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note