Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #12287

What problem does this PR solve?

Issue Number: close #12286

What is changed and how it works?

  1. DDLs can be skipped in the ddlPuller by setting IgnoreTxnStartTs in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
  1. create a changefeed.
  2. execute follow ddl upstream
create table a (a bigint primary key, b int);
create table b like a;
rename table a to c, b to a, c to b;
  1. changefeed meets the following error:
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "warning",
      "tso": 460194169340821515,
      "checkpoint": "2025-08-18 15:17:19.441",
      "error": {
        "time": "2025-08-18T15:17:20.493361+08:00",
        "addr": "127.0.0.1:8300",
        "code": "CDC:ErrHandleDDLFailed",
        "message": "[CDC:ErrHandleDDLFailed]handle ddl failed, query: rename table a to c, b to a, c to b, startTs: 460194169353928710. If you want to skip this DDL and continue with replication, you can manually execute this DDL downstream. Afterwards, add `ignore-txn-start-ts=[460194169353928710]` to the changefeed in the filter configuration.: [CDC:ErrSnapshotTableNotFound]table 112 not found in schema snapshot"
  1. Adjust changefeed filter config file cf.toml, add the ignore-txn-start-ts=[460194169353928710] to filter.
[filter]
ignore-txn-start-ts = [460194169353928710]
  1. Update chagnefeed with cf.toml.
./cdc cli changefeed update -c test --config=cf.toml 
  1. resume changefeed, chagnefeed resume to normal.
> ./cdc cli changefeed list
[
  {
    "id": "test",
    "namespace": "default",
    "summary": {
      "state": "normal",
      "tso": 460194185921429508,
      "checkpoint": "2025-08-18 15:18:22.691",
      "error": null
    }
  }
]

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Support discarding unsupported DDL by setting `ignore-txn-start-ts` in filter.

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Aug 18, 2025
@ti-chi-bot
Copy link
Member Author

@asddongmen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

Copy link
Contributor

ti-chi-bot bot commented Aug 18, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the DDL (Data Definition Language) filtering capabilities within the ddlPuller component. The primary goal is to provide users with a mechanism to explicitly ignore specific DDL operations based on their transaction start timestamp. This new functionality is crucial for scenarios where TiCDC encounters DDLs it cannot process, allowing users to configure the system to skip these problematic DDLs and prevent changefeeds from entering a warning or error state. The changes involve modifying the DDL filtering interface to accept transaction timestamps and updating the DDL puller to utilize this new filtering criterion, along with refined handling for multi-table DDLs.

Highlights

  • Enhanced DDL Filtering: The core filtering logic for DDLs (ShouldDiscardDDL) now accepts a transaction start timestamp (startTs), enabling more granular control over which DDLs are processed or ignored.
  • New ignore-txn-start-ts Configuration: A new configuration option, ignore-txn-start-ts, has been introduced, allowing users to specify a list of transaction timestamps for DDLs that should be explicitly discarded by the ddlPuller. This is particularly useful for skipping DDLs that TiCDC cannot handle, preventing changefeed errors.
  • DDL Puller Integration: The DDL puller's handleJob function has been updated to leverage this new startTs parameter, ensuring that DDLs are filtered not only by type, schema, and table but also by their specific transaction timestamp.
  • Refined Multi-Table DDL Processing: Improved handling for complex DDLs like CREATE TABLES and RENAME TABLE allows the filter to apply to individual tables within these multi-table operations, providing more precise control over DDL replication.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to discard unsupported DDLs by specifying their start-ts in the changefeed filter configuration. This is a useful feature for unblocking replication when encountering problematic DDLs. The changes span across the DDL puller and filter logic, with corresponding updates to tests.

However, the pull request contains several unresolved merge conflicts, which makes the code uncompilable. These must be resolved. Additionally, there is a compilation error in cdc/puller/ddl_puller.go due to usage of an undefined variable. These critical issues need to be addressed before this PR can be merged.

Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
@asddongmen
Copy link
Contributor

/test pull-dm-integration-test

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 19, 2025
Copy link
Contributor

ti-chi-bot bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 20, 2025
@asddongmen asddongmen removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit 041c9fb into pingcap:release-7.5 Aug 20, 2025
11 of 12 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-12287-to-release-7.5 branch August 20, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants