-
Notifications
You must be signed in to change notification settings - Fork 293
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter. (#12287)
#12290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
puller: Support discarding unsupported DDL by setting ignore-txn-start-ts
in filter. (#12287)
#12290
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@asddongmen This PR has conflicts, I have hold it. |
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the DDL (Data Definition Language) filtering capabilities within the ddlPuller
component. The primary goal is to provide users with a mechanism to explicitly ignore specific DDL operations based on their transaction start timestamp. This new functionality is crucial for scenarios where TiCDC encounters DDLs it cannot process, allowing users to configure the system to skip these problematic DDLs and prevent changefeeds from entering a warning or error state. The changes involve modifying the DDL filtering interface to accept transaction timestamps and updating the DDL puller to utilize this new filtering criterion, along with refined handling for multi-table DDLs.
Highlights
- Enhanced DDL Filtering: The core filtering logic for DDLs (
ShouldDiscardDDL
) now accepts a transaction start timestamp (startTs
), enabling more granular control over which DDLs are processed or ignored. - New
ignore-txn-start-ts
Configuration: A new configuration option,ignore-txn-start-ts
, has been introduced, allowing users to specify a list of transaction timestamps for DDLs that should be explicitly discarded by theddlPuller
. This is particularly useful for skipping DDLs that TiCDC cannot handle, preventing changefeed errors. - DDL Puller Integration: The DDL puller's
handleJob
function has been updated to leverage this newstartTs
parameter, ensuring that DDLs are filtered not only by type, schema, and table but also by their specific transaction timestamp. - Refined Multi-Table DDL Processing: Improved handling for complex DDLs like
CREATE TABLES
andRENAME TABLE
allows the filter to apply to individual tables within these multi-table operations, providing more precise control over DDL replication.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a feature to discard unsupported DDLs by specifying their start-ts
in the changefeed filter configuration. This is a useful feature for unblocking replication when encountering problematic DDLs. The changes span across the DDL puller and filter logic, with corresponding updates to tests.
However, the pull request contains several unresolved merge conflicts, which makes the code uncompilable. These must be resolved. Additionally, there is a compilation error in cdc/puller/ddl_puller.go
due to usage of an undefined variable. These critical issues need to be addressed before this PR can be merged.
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
Signed-off-by: dongmen <[email protected]>
/test pull-dm-integration-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #12287
What problem does this PR solve?
Issue Number: close #12286
What is changed and how it works?
IgnoreTxnStartTs
in the filter configuration. It is also helpful when we need to skip DDLs that cannot be handled by TiCDC.Check List
Tests
cf.toml
, add theignore-txn-start-ts=[460194169353928710]
to filter.cf.toml
.Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note