Skip to content

fix(SelectPanel): add loading state to stories #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2025
Merged

fix(SelectPanel): add loading state to stories #6374

merged 7 commits into from
Jul 23, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Jul 23, 2025 •
edited
Loading

Changelog

Changed

  • use explicit loading status in stories that have an empty message

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@Copilot Copilot AI review requested due to automatic review settings July 23, 2025 20:28
@francinelucca francinelucca requested a review from a team as a code owner July 23, 2025 20:28
@francinelucca francinelucca requested a review from hectahertz July 23, 2025 20:28
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 074421e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jul 23, 2025
Copilot
Copilot AI reviewed Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds loading state functionality to SelectPanel stories to demonstrate async data fetching behavior in Storybook. The changes ensure that the SelectPanel component properly shows loading states during simulated API calls.

  • Adds loading state management to async fetch stories
  • Implements initial loading behavior with useEffect hooks
  • Updates component props to pass loading state to SelectPanel

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.21 KB (0%)
packages/react/dist/browser.umd.js 92.39 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6374 July 23, 2025 20:34 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6374 July 23, 2025 20:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-6374 July 23, 2025 20:54 Inactive
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
llastflowers

This comment was marked as resolved.

Sign in to view

@llastflowers llastflowers self-requested a review July 23, 2025 20:59
llastflowers
llastflowers approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@llastflowers llastflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good--stories with loading work as expected ✅

@primer primer bot requested a review from a team as a code owner July 23, 2025 21:07
@primer primer bot requested a review from mperrotti July 23, 2025 21:07
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 23, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6374 July 23, 2025 21:17 Inactive
@github-actions github-actions bot requested a deployment to storybook-preview-6374 July 23, 2025 21:26 Abandoned
@joshblack joshblack merged commit ad76aa8 into main Jul 23, 2025
43 checks passed
@joshblack joshblack deleted the fix/selectpanel-stories-fix branch July 23, 2025 21:36
@primer primer bot mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@llastflowers llastflowers llastflowers approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti was automatically assigned from primer/design-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francinelucca @llastflowers @joshblack