Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/selfish-papayas-smoke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

fix(SelectPanel): add loading state to stories
26 changes: 23 additions & 3 deletions packages/react/src/SelectPanel/SelectPanel.features.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useState, useRef} from 'react'
import React, {useState, useRef, useEffect} from 'react'
import type {Meta, StoryObj} from '@storybook/react-vite'
import Box from '../Box'
import {Button} from '../Button'
Expand Down Expand Up @@ -557,6 +557,7 @@ export const AsyncFetch: StoryObj<SelectPanelProps> = {
const [open, setOpen] = useState(false)
const filterTimerId = useRef<number | null>(null)
const {safeSetTimeout, safeClearTimeout} = useSafeTimeout()
const [loading, setLoading] = useState(true)
const [query, setQuery] = useState('')

const fetchItems = (query: string) => {
Expand All @@ -565,11 +566,21 @@ export const AsyncFetch: StoryObj<SelectPanelProps> = {
setQuery(query)
}

setLoading(true)
filterTimerId.current = safeSetTimeout(() => {
setFilteredItems(items.filter(item => item.text.toLowerCase().startsWith(query.toLowerCase())))
setLoading(false)
}, 2000) as unknown as number
}

useEffect(() => {
filterTimerId.current = safeSetTimeout(() => {
setFilteredItems(items.filter(item => item.text.toLowerCase().startsWith(query.toLowerCase())))
setLoading(false)
}, 2000) as unknown as number
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [])

const onOpenChange = (value: boolean) => {
setOpen(value)
fetchItems('')
Expand Down Expand Up @@ -600,6 +611,7 @@ export const AsyncFetch: StoryObj<SelectPanelProps> = {
height={height}
initialLoadingType={initialLoadingType}
width="medium"
loading={loading}
message={filteredItems.length === 0 ? NoResultsMessage(query) : undefined}
/>
)
Expand Down Expand Up @@ -679,20 +691,28 @@ export const CustomisedNoResults: StoryObj<typeof SelectPanel> = {
const [open, setOpen] = useState(false)
const filterTimerId = useRef<number | null>(null)
const {safeSetTimeout, safeClearTimeout} = useSafeTimeout()
const [loading, setLoading] = useState(false)
const [loading, setLoading] = useState(true)
const onFilterChange = (value: string) => {
setFilterValue(value)
if (filterTimerId.current) {
safeClearTimeout(filterTimerId.current)
}
setLoading(true)

setLoading(true)
filterTimerId.current = safeSetTimeout(() => {
setFilteredItems(items.filter(item => item.text.toLowerCase().startsWith(value.toLowerCase())))
setLoading(false)
}, 2000) as unknown as number
}

useEffect(() => {
filterTimerId.current = safeSetTimeout(() => {
setFilteredItems(items.filter(item => item.text.toLowerCase().startsWith(filterValue.toLowerCase())))
setLoading(false)
}, 2000) as unknown as number
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [])

return (
<SelectPanel
title="Select labels"
Expand Down
Loading