[v24.2.x] rpk: improve rpk debug bundle assumptions in k8s environments #26214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Mac users. We won't need this now that we have upgraded to Bazel 8. (cherry picked from commit 17cbc78)
We had build tags for the other files already. We previously missed the build tag on this file. (cherry picked from commit 1dc1a5e)
rpk debug bundle works on a best-effort basis. It always tries to return a bundle—even if some steps (like logs or resource collection) fail. Sometimes, is because the system is unhealthy leading to expected errors. Seeing errors doesn't mean the bundle is useless. This change aims to make this clearer for the user. (cherry picked from commit 066732a)
If --namespace is not provided, fallback to $NAMESPACE, then /var/run/secrets/kubernetes.io/serviceaccount/namespace, and finally default to "redpanda". This avoids hardcoding and better supports various deployment environments. (cherry picked from commit adb9d38)
When collecting a debug bundle from a k8s environment, we now: - Log a warning if admin addresses cannot be retrieved from the k8s API. - Use the union of the profile-defined admin addresses and those returned by the k8s API. - Fall back to 127.0.0.1 if no addresses are available from either source. - Log the final list of admin addresses used. This improves reliability and visibility in environments with incomplete or misconfigured cluster info. (cherry picked from commit 939e1ba)
We will stop assuming `redpanda` to be the default container name. Instead we are going to fetch the logs of all containers and initContainers in the namespace/pod. Logs will still be stored under logs/ (cherry picked from commit d66c6b0)
|
Depends on #26217 as we recently bumped Go and we need to bump Tiny Go in v24.2.x branch. |
Retry command for Build#66319please wait until all jobs are finished before running the slash command |
CI test resultstest results on build#66319
|
|
/ci-repeat 1 |
andresaristizabal
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26091
Backports Required
Release Notes
Improvements