refactor(Worklets): extract RuntimeData file #7905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extracts runtime-related constants and data from RuntimeManager into a new RuntimeData file to prevent circular dependencies in future refactors.
- Moves runtime ID constants (
rnRuntimeId,uiRuntimeId) and theuiRuntimeNamestring from RuntimeManager to new RuntimeData files - Creates new RuntimeData.h and RuntimeData.cpp files to house the extracted data
- Updates include statements in WorkletRuntime.h and RuntimeManager.h to reference the new RuntimeData header
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| RuntimeData.h | New header file containing runtime ID constants and uiRuntimeName declaration |
| RuntimeData.cpp | New implementation file with uiRuntimeName definition |
| RuntimeManager.h | Removes runtime constants and adds RuntimeData include |
| RuntimeManager.cpp | Removes uiRuntimeName definition |
| WorkletRuntime.h | Adds RuntimeData include |
packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeData.h
Show resolved
Hide resolved
piaskowyk
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To prevent circular dependencies in future refactors.
Test plan
CI