Skip to content

refactor(Worklets): extract RuntimeData file #7905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

refactor(Worklets): extract RuntimeData file #7905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#include <worklets/WorkletRuntime/RuntimeData.h>

const std::string uiRuntimeName{"UI"};
10 changes: 10 additions & 0 deletions packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeData.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#pragma once

#include <string>

/**
* Unused, but kept for possible future use.
*/
constexpr uint64_t rnRuntimeId{0};
constexpr uint64_t uiRuntimeId{1};
extern const std::string uiRuntimeName;
2 changes: 0 additions & 2 deletions packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

namespace worklets {

const std::string uiRuntimeName{"UI"};

std::shared_ptr<WorkletRuntime> RuntimeManager::getRuntime(uint64_t runtimeId) {
std::shared_lock lock(weakRuntimesMutex_);
if (weakRuntimes_.contains(runtimeId)) {
Expand Down
8 changes: 1 addition & 7 deletions packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <jsi/jsi.h>
#include <worklets/Tools/UIScheduler.h>
#include <worklets/WorkletRuntime/RuntimeData.h>
#include <worklets/WorkletRuntime/WorkletRuntime.h>

#include <atomic>
Expand All @@ -18,13 +19,6 @@ namespace worklets {
*/
class JSIWorkletsModuleProxy;

/**
* Unused, but kept for possible future use.
*/
constexpr uint64_t rnRuntimeId{0};
constexpr uint64_t uiRuntimeId{1};
extern const std::string uiRuntimeName;

class RuntimeManager {
public:
std::shared_ptr<WorkletRuntime> getRuntime(uint64_t runtimeId);
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <worklets/SharedItems/Shareables.h>
#include <worklets/Tools/AsyncQueueImpl.h>
#include <worklets/Tools/JSScheduler.h>
#include <worklets/WorkletRuntime/RuntimeData.h>

#include <memory>
#include <string>
Expand Down
Loading