Reduce CPU usage by instead fetching read receipts after related sync events #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #111 |
This implementation results in very high CPU usage with large rooms, where we are iterating over all members every few seconds. Most members do not have a read receipt attached to any loaded events, and most read receipts that are attached to a loaded event do not change frequently.
This re-enables handling for read receipt changes that occur after iamb is launched, but does not show any read receipts that were last updated in a previous run and persisted to the db.
This re-enables read receipts that were persisted to the db on a previous run of 'iamb'.
This is the last bit of functionality from the previous read receipt implementation. It's still a polling loop, but does _significantly_ less work.
olivia-fl
force-pushed
the
faster-receipts
branch
from
1cfb932 to
c90b08e
Compare
ulyssa
changed the title
|
Thank you for digging into this, @Benjamin-L ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my machine, this reduces idle CPU usage from 150% to ~0.5%.