perf(nm): Speedup hardlinks-global link step by 1.5-1.7x
#4532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Merged into #4533 as well, |
merceyz
approved these changes
Oct 18, 2022
❌ Deploy Preview for leafy-naiad-142cc5 failed.
|
merceyz
added a commit
that referenced
this pull request
Nov 3, 2022
* Speedup hardlinks-global link step by 1.5-1.7x * Adjust mtime comparison to detect immediate file writes * Adds a test to check store modification in the past * Adds changelog entry * chore: update changelog * chore: remove old changelog entry Co-authored-by: Maël Nison <[email protected]> Co-authored-by: merceyz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Speeds up nm linker link step for
hardlinks-globalmode.How did you fix it?
Because all the hardlinks pointing to the same file share the same
mtimethe nm linker now utilizes this fact. It checks whether the filemtimewithin a small 1 second range which was memorized in the content addressable store and uses it as the fact that the file in the content addressable store was not changed. If themtimediffers the linker will proceed with checking contents checksums as previously.Checklist