feat(plugin-pnpm): Content-addressable storage support #4533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arcanis
reviewed
Jun 9, 2022
| } | { | ||
| kind: DirEntryKind. DIRECTORY; | ||
| } | { | ||
| kind: DirEntryKind.SYMLINK; | ||
| symlinkTo: PortablePath; | ||
| }; | ||
|
|
||
| const copyPromise = async (dstDir: PortablePath, srcDir: PortablePath, {baseFs, globalHardlinksStore, nmMode, packageChecksum}: {baseFs: FakeFS<PortablePath>, globalHardlinksStore: PortablePath | null, nmMode: {value: NodeModulesMode}, packageChecksum: string | null}) => { | ||
| export const copyPromise = async (dstDir: PortablePath, srcDir: PortablePath, {baseFs, hardlinksStorePath, nmMode, packageChecksum}: {baseFs: FakeFS<PortablePath>, hardlinksStorePath: PortablePath | null, nmMode: {value: NodeModulesMode}, packageChecksum: string | null}) => { |
There was a problem hiding this comment.
I'm really not fan of having a separate copy function... It was fine when it was bound to the nm linker, but if it leaks into the others it starts to become concerning imo 🤔
There was a problem hiding this comment.
Please review #4532 then, I've reopened it
This comment was marked as off-topic.
This comment was marked as off-topic.
3 tasks
2 tasks
|
Closed in favour of: #4586, although the latter has worse performance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR implements content-addressable storage support for
pnpmlinker vianmMode: hardlinks-globalconfig setting.Integrates PR: #4532
How did you fix it?
The PR is reusing
hardlinks-globalimplementation fromnode-moduleslinker.pnpmlinker link step timings on one of my rather big projects:master(no hardlinks store): 18.9 secsnmMode: hardlinks-global, empty store): 37.8 secsnmMode: hardlinks-global, filled store): 15.2 secs, it is a bit slower than wihout hardlinks, because content addressable store needs more fs operations on packages without checksums, which is the case for conditional packages likefseventsChecklist