statistics: use infoschema api to get table info #57574

hawkingrei · 2024-11-21T04:06:57Z

What problem does this PR solve?

Issue Number: close #57573

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <[email protected]>

codecov · 2024-11-21T04:47:39Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.9399%. Comparing base (e4e707d) to head (e49e268).
Report is 14 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57574        +/-   ##
================================================
+ Coverage   72.8372%   73.9399%   +1.1026%     
================================================
  Files          1676       1706        +30     
  Lines        463627     473966     +10339     
================================================
+ Hits         337693     350450     +12757     
+ Misses       105112     102229      -2883     
- Partials      20822      21287       +465

Flag	Coverage Δ
integration	`46.7223% <100.0000%> (?)`
unit	`72.5770% <100.0000%> (+0.3492%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7673% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`45.4449% <ø> (-0.0176%)`	⬇️

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2024-11-21T06:27:07Z

/test fast_test_tiprow

tiprow · 2024-11-21T06:27:24Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2024-11-21T06:35:56Z

/test fast_test_tiprow

tiprow · 2024-11-21T06:36:12Z

@ti-chi-bot[bot]: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test fast_test_tiprow
/test fast_test_tiprow_ddlargsv1
/test tidb_parser_test

Use /test all to run the following jobs that were automatically triggered:

fast_test_tiprow
tidb_parser_test

In response to this:

@hawkingrei: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:
/test build
/test check-dev
/test check-dev2
/test mysql-test
/test pull-br-integration-test
/test pull-integration-ddl-test
/test pull-integration-e2e-test
/test pull-lightning-integration-test
/test pull-mysql-client-test
/test pull-unit-test-ddlv1
/test unit-test
The following commands are available to trigger optional jobs:
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-nodejs-test
/test pull-integration-python-orm-test
/test pull-sqllogic-test
/test pull-tiflash-test
Use /test all to run the following jobs that were automatically triggered:
pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pingcap/tidb/pull_integration_ddl_test
pingcap/tidb/pull_integration_e2e_test
pingcap/tidb/pull_lightning_integration_test
pingcap/tidb/pull_mysql_client_test
In response to this:

/test fast_test_tiprow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

pkg/statistics/handle/util/table_info.go

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei · 2024-11-21T08:00:48Z

/retest

hawkingrei · 2024-11-21T08:32:39Z

/retest

ti-chi-bot · 2024-11-21T15:05:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/statistics/OWNERS~~ [winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-21T15:05:30Z

[LGTM Timeline notifier]

Timeline:

2024-11-21 08:16:31.033946397 +0000 UTC m=+105978.653600912: ☑️ agreed by lance6716.
2024-11-21 15:05:28.990541292 +0000 UTC m=+130516.610195808: ☑️ agreed by winoros.

ti-chi-bot · 2024-11-22T02:38:35Z

In response to a cherrypick label: new pull request created to branch release-8.5: #57614.

close #57573

* skip TestIndexJoin31494 * fix * global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356) * statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298) * executor: Fix the parse problematic slow log panic issue due to empty … * statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268) * br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262) * log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265) * executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236) * statistics: copy stats when to update it for avoiding data race (pingcap#5810… * domain,infoschema: make infoschema activity block GC safepoint advanci… * planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035) * statistics: right deal with error for reading stats from storage (pingcap#58… * statistics: lite init used wrong value to build table stats ver (pingcap#5802… * lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS (pingcap#5… * *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997) * ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989) * *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951) * lightning: add PK to internal tables (pingcap#57480) (pingcap#57932) * statistics: correct behavior of non-lite InitStats and stats sync load… * statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911) * dumpling: use I_S to get table list for TiDB and add database to WHERE… * br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907) * statistics: do not record historical stats meta if the table is locked… * metrics: remove the filled colors (pingcap#57838) (pingcap#57866) * planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870) * *: support cancel query like 'select * from information_schema.tables'… * session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161) * ddl: Fixed partitioning a non-partitioned table with placement rules (… * *: Reorg partition fix delete ranges and handling non-clustered tables… * executor: fix query infoschema.tables table_schema/table_name with fil… * ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820) * ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801) * *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724) * br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802) * statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775) * expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688) * statistics: rightly deal with timout when to send sync load (pingcap#57712) (pingcap#57751) * ddl: `tidb_scatter_region` variable supports setting value in both upp… * planner: fix that vector index output empty result when pk is non-int … * ddl: dynamically adjusting the max write speed of reorganization job (… * executor: fix hang in hash agg when exceeding memory limit leads to pa… * statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614) * planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689) * statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674) * backup: reset timeout on store level (pingcap#55526) (pingcap#57667) * planner/core: fix a wrong privilege check for CTE & UPDATE statement (…

hawkingrei added 2 commits November 21, 2024 12:23

statistics: use infoschema api to get table info

21c1842

Signed-off-by: Weizhen Wang <[email protected]>

statistics: use infoschema api to get table info

d93e9a1

Signed-off-by: Weizhen Wang <[email protected]>

hawkingrei force-pushed the 57573 branch from 98fb5a6 to d93e9a1 Compare November 21, 2024 04:23

statistics: use infoschema api to get table info

142cf9d

Signed-off-by: Weizhen Wang <[email protected]>

statistics: use infoschema api to get table info

9bc3a6f

Signed-off-by: Weizhen Wang <[email protected]>

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Nov 21, 2024

pingcap deleted a comment from ti-chi-bot bot Nov 21, 2024

lance6716 reviewed Nov 21, 2024

View reviewed changes

pkg/statistics/handle/util/table_info.go Outdated Show resolved Hide resolved

hawkingrei added 2 commits November 21, 2024 14:59

statistics: use infoschema api to get table info

287a835

Signed-off-by: Weizhen Wang <[email protected]>

statistics: use infoschema api to get table info

e49e268

Signed-off-by: Weizhen Wang <[email protected]>

pingcap deleted a comment from ti-chi-bot bot Nov 21, 2024

lance6716 approved these changes Nov 21, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024

winoros approved these changes Nov 21, 2024

View reviewed changes

ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024

ti-chi-bot bot merged commit d42a36d into pingcap:master Nov 21, 2024
25 checks passed

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 22, 2024

ti-chi-bot mentioned this pull request Nov 22, 2024

statistics: use infoschema api to get table info (#57574) #57614

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Nov 25, 2024

statistics: use infoschema api to get table info (#57574) (#57614)

6e860ce

close #57573

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

statistics: use infoschema api to get table info #57574

statistics: use infoschema api to get table info #57574

Uh oh!

hawkingrei commented Nov 21, 2024 •

edited

Loading

Uh oh!

codecov bot commented Nov 21, 2024 •

edited

Loading

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

tiprow bot commented Nov 21, 2024

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

tiprow bot commented Nov 21, 2024

Uh oh!

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

ti-chi-bot bot commented Nov 21, 2024

Uh oh!

ti-chi-bot bot commented Nov 21, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Nov 22, 2024

Uh oh!

Uh oh!

statistics: use infoschema api to get table info #57574

statistics: use infoschema api to get table info #57574

Uh oh!

Conversation

hawkingrei commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

codecov bot commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

tiprow bot commented Nov 21, 2024

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

tiprow bot commented Nov 21, 2024

Uh oh!

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

hawkingrei commented Nov 21, 2024

Uh oh!

ti-chi-bot bot commented Nov 21, 2024

Uh oh!

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Uh oh!

Uh oh!

ti-chi-bot commented Nov 22, 2024

Uh oh!

Uh oh!

hawkingrei commented Nov 21, 2024 •

edited

Loading

codecov bot commented Nov 21, 2024 •

edited

Loading