Skip to content

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Nov 29, 2024

What problem does this PR solve?

Issue Number: close #57835

Problem Summary:

What changed and how does it work?

Remove the filled colors in Grafana script.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. start a cluster
  2. deploy this patch
  3. check the grafana
image
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 29, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2024
Copy link

ti-chi-bot bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 29, 2024
Copy link

ti-chi-bot bot commented Nov 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-29 08:54:34.031377175 +0000 UTC m=+799461.651031692: ☑️ agreed by hawkingrei.
  • 2024-11-29 08:56:09.387905048 +0000 UTC m=+799557.007559561: ☑️ agreed by lance6716.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4351%. Comparing base (d3936a2) to head (1704793).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57838        +/-   ##
================================================
+ Coverage   72.8544%   73.4351%   +0.5807%     
================================================
  Files          1677       1677                
  Lines        464466     464509        +43     
================================================
+ Hits         338384     341113      +2729     
+ Misses       105185     102599      -2586     
+ Partials      20897      20797       -100     
Flag Coverage Δ
integration 43.5555% <ø> (?)
unit 72.2572% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7347% <ø> (+0.0090%) ⬆️

@hawkingrei
Copy link
Member

/retest

Copy link

tiprow bot commented Nov 29, 2024

@jackysp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 1704793 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 56e705c into pingcap:master Nov 29, 2024
23 of 24 checks passed
@hawkingrei
Copy link
Member

/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #57866.

In response to this:

/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 2, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 2, 2024
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 4, 2025
* skip TestIndexJoin31494
* fix
* global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356)
* statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298)
* executor: Fix the parse problematic slow log panic issue due to empty …
* statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268)
* br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262)
* log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265)
* executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236)
* statistics: copy stats when to update it for avoiding data race (pingcap#5810…
* domain,infoschema: make infoschema activity block GC safepoint advanci…
* planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035)
* statistics: right deal with error for reading stats from storage  (pingcap#58…
* statistics: lite init used wrong value to build table stats ver (pingcap#5802…
* lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS  (pingcap#5…
* *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997)
* ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989)
* *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951)
* lightning: add PK to internal tables (pingcap#57480) (pingcap#57932)
* statistics: correct behavior of non-lite InitStats and stats sync load…
* statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911)
* dumpling: use I_S to get table list for TiDB and add database to WHERE…
* br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907)
* statistics: do not record historical stats meta if the table is locked…
* metrics: remove the filled colors (pingcap#57838) (pingcap#57866)
* planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870)
* *: support cancel query like 'select * from information_schema.tables'…
* session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161)
* ddl: Fixed partitioning a non-partitioned table with placement rules (…
* *: Reorg partition fix delete ranges and handling non-clustered tables…
* executor: fix query infoschema.tables table_schema/table_name with fil…
* ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820)
* ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801)
* *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724)
* br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802)
* statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775)
* expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688)
* statistics: rightly deal with timout when to send sync load  (pingcap#57712) (pingcap#57751)
* ddl: `tidb_scatter_region` variable supports setting value in both upp…
* planner: fix that vector index output empty result when pk is non-int …
* ddl: dynamically adjusting the max write speed of reorganization job (…
* executor: fix hang in hash agg when exceeding memory limit leads to pa…
* statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614)
* planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689)
* statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674)
* backup: reset timeout on store level (pingcap#55526) (pingcap#57667)
* planner/core: fix a wrong privilege check for CTE & UPDATE statement (…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics should not filled with color
4 participants