planner: handle panic when loading bindings at startup #58017

qw4990 · 2024-12-05T11:49:07Z

What problem does this PR solve?

Issue Number: close #58016

Problem Summary: planner: handle panic when loading bindings at startup

What changed and how does it work?

planner: handle panic when loading bindings at startup

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2024-12-05T11:49:23Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2024-12-05T11:52:06Z

This is hard to test through UT so I only tested it manually.
Before this PR, TiDB panic when restarting:

After this PR, it can handle and log the panic and restart normally:

codecov · 2024-12-05T12:19:14Z

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5990%. Comparing base (a4278e0) to head (19de2e7).
Report is 545 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58017        +/-   ##
================================================
+ Coverage   73.1368%   73.5990%   +0.4621%     
================================================
  Files          1674       1674                
  Lines        461123     462961      +1838     
================================================
+ Hits         337251     340735      +3484     
+ Misses       103107     101514      -1593     
+ Partials      20765      20712        -53

Flag	Coverage Δ
integration	`43.3227% <40.0000%> (?)`
unit	`72.3557% <40.0000%> (+0.0931%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.0134% <ø> (+0.0120%)`	⬆️

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ti-chi-bot · 2024-12-05T13:09:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/bindinfo/OWNERS~~ [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-05T13:09:10Z

[LGTM Timeline notifier]

Timeline:

2024-12-05 12:24:04.796335984 +0000 UTC m=+1330432.415990496: ☑️ agreed by hawkingrei.
2024-12-05 13:09:08.869682253 +0000 UTC m=+1333136.489336768: ☑️ agreed by time-and-fate.

ti-chi-bot · 2024-12-06T02:43:33Z

In response to a cherrypick label: new pull request created to branch release-8.5: #58035.

close #58016

hawkingrei · 2024-12-11T10:27:40Z

/cherrypick release-8.1
/cherrypick release-7.5

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-12-11T10:28:23Z

@hawkingrei: new pull request created to branch release-7.5: #58169.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-12-11T10:29:05Z

@hawkingrei: new pull request created to branch release-8.1: #58170.

In response to this:

/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #58016

ti-chi-bot · 2025-01-21T03:38:03Z

In response to a cherrypick label: new pull request created to branch release-6.5: #59062.

Signed-off-by: ti-chi-bot <[email protected]>

close #58016

* skip TestIndexJoin31494 * fix * global sort: add boundaries to split keys when generating plan (pingcap#58323) (pingcap#58356) * statistics: get right max table id when to init stats (pingcap#58280) (pingcap#58298) * executor: Fix the parse problematic slow log panic issue due to empty … * statstics: trigger evict by the timer (pingcap#58027) (pingcap#58268) * br: make table existence check unified on different br client (pingcap#58211) (pingcap#58262) * log backup: use global checkpoint ts as source of truth (pingcap#58135) (pingcap#58265) * executor: skip execution when build query for VIEW in I_S (pingcap#58203) (pingcap#58236) * statistics: copy stats when to update it for avoiding data race (pingcap#5810… * domain,infoschema: make infoschema activity block GC safepoint advanci… * planner: handle panic when loading bindings at startup (pingcap#58017) (pingcap#58035) * statistics: right deal with error for reading stats from storage (pingcap#58… * statistics: lite init used wrong value to build table stats ver (pingcap#5802… * lightning, ddl: set TS to engineMeta after ResetEngineSkipAllocTS (pingcap#5… * *: avoid unlock of unlocked mutex panic on TableDeltaMap (pingcap#57799) (pingcap#57997) * ddl: handle context done after sending DDL jobs (pingcap#57945) (pingcap#57989) * *: activate txn for query on infoschema tables (pingcap#57937) (pingcap#57951) * lightning: add PK to internal tables (pingcap#57480) (pingcap#57932) * statistics: correct behavior of non-lite InitStats and stats sync load… * statistics: avoid stats meta full load after table analysis (pingcap#57756) (pingcap#57911) * dumpling: use I_S to get table list for TiDB and add database to WHERE… * br: fix insert gc failed due to slow schema reload (pingcap#57742) (pingcap#57907) * statistics: do not record historical stats meta if the table is locked… * metrics: remove the filled colors (pingcap#57838) (pingcap#57866) * planner: use TableInfo.DBID to locate schema (pingcap#57785) (pingcap#57870) * *: support cancel query like 'select * from information_schema.tables'… * session: make `TxnInfo()` return even if process info is empty (pingcap#57044) (pingcap#57161) * ddl: Fixed partitioning a non-partitioned table with placement rules (… * *: Reorg partition fix delete ranges and handling non-clustered tables… * executor: fix query infoschema.tables table_schema/table_name with fil… * ddl: check context done in isReorgRunnable function (pingcap#57813) (pingcap#57820) * ddl: fix ExistsTableRow and add tests for skip reorg checks (pingcap#57778) (pingcap#57801) * *: Fix for TRUNCATE PARTITION and Global Index (pingcap#57724) * br: prompt k8s.io/api version (pingcap#57791) (pingcap#57802) * statistics: fix some problem related to stats async load (pingcap#57723) (pingcap#57775) * expression: fix wrong calculation order of `radians` (pingcap#57672) (pingcap#57688) * statistics: rightly deal with timout when to send sync load (pingcap#57712) (pingcap#57751) * ddl: `tidb_scatter_region` variable supports setting value in both upp… * planner: fix that vector index output empty result when pk is non-int … * ddl: dynamically adjusting the max write speed of reorganization job (… * executor: fix hang in hash agg when exceeding memory limit leads to pa… * statistics: use infoschema api to get table info (pingcap#57574) (pingcap#57614) * planner: Use realtimeRowCount when all topN collected (pingcap#56848) (pingcap#57689) * statistics: handle deleted tables correctly in the PQ (pingcap#57649) (pingcap#57674) * backup: reset timeout on store level (pingcap#55526) (pingcap#57667) * planner/core: fix a wrong privilege check for CTE & UPDATE statement (…

qw4990 added 2 commits December 5, 2024 19:46

handle panic when loading bindings when restaring

1f34242

handle panic when loading bindings when restaring

4b3e5c6

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024

handle panic when loading bindings when restaring

19de2e7

ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024

hawkingrei approved these changes Dec 5, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024

time-and-fate approved these changes Dec 5, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024

ti-chi-bot bot merged commit 821563f into pingcap:master Dec 5, 2024
24 checks passed

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 6, 2024

ti-chi-bot mentioned this pull request Dec 6, 2024

planner: handle panic when loading bindings at startup (#58017) #58035

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024

planner: handle panic when loading bindings at startup (#58017) (#58035)

9db025d

close #58016

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 11, 2024

This is an automated cherry-pick of pingcap#58017

1d91121

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Dec 11, 2024

planner: handle panic when loading bindings at startup (#58017) #58169

Merged

13 tasks

ti-chi-bot mentioned this pull request Dec 11, 2024

planner: handle panic when loading bindings at startup (#58017) #58170

Open

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024

planner: handle panic when loading bindings at startup (#58017) (#58169)

b9d536d

close #58016

ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 21, 2025

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 21, 2025

This is an automated cherry-pick of pingcap#58017

8a98b55

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jan 21, 2025

planner: handle panic when loading bindings at startup (#58017) #59062

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Feb 8, 2025

planner: handle panic when loading bindings at startup (#58017) (#59062)

7ee327f

close #58016

qw4990 added the type/bugfix This PR fixes a bug. label Mar 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

planner: handle panic when loading bindings at startup #58017

planner: handle panic when loading bindings at startup #58017

Uh oh!

qw4990 commented Dec 5, 2024

Uh oh!

tiprow bot commented Dec 5, 2024

Uh oh!

qw4990 commented Dec 5, 2024

Uh oh!

codecov bot commented Dec 5, 2024 •

edited

Loading

Uh oh!

ti-chi-bot bot commented Dec 5, 2024

Uh oh!

ti-chi-bot bot commented Dec 5, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Dec 6, 2024

Uh oh!

hawkingrei commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Jan 21, 2025

Uh oh!

Uh oh!

planner: handle panic when loading bindings at startup #58017

planner: handle panic when loading bindings at startup #58017

Uh oh!

Conversation

qw4990 commented Dec 5, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Dec 5, 2024

Uh oh!

qw4990 commented Dec 5, 2024

Uh oh!

codecov bot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ti-chi-bot bot commented Dec 5, 2024

Uh oh!

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Uh oh!

Uh oh!

ti-chi-bot commented Dec 6, 2024

Uh oh!

hawkingrei commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Dec 11, 2024

Uh oh!

ti-chi-bot commented Jan 21, 2025

Uh oh!

Uh oh!

codecov bot commented Dec 5, 2024 •

edited

Loading