ddl: Fixed partition interval from DayMinute to just Minute. #57738

mjonss · 2024-11-26T13:36:31Z

What problem does this PR solve?

Issue Number: close #57698

Problem Summary:
A typo using ast.TimeUnitDayMinute instead of ast.TimeUnitMinute lead to PARTITION BY INTERVAL by minute did not work

What changed and how does it work?

Fixed the typo

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed issue that would not allow MINUTE for interval partitioning.

tiprow · 2024-11-26T13:36:49Z

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-11-26T13:53:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.5724%. Comparing base (b11d034) to head (957f2d4).
Report is 77 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #57738        +/-   ##
================================================
+ Coverage   72.8126%   75.5724%   +2.7598%     
================================================
  Files          1677       1722        +45     
  Lines        463954     479721     +15767     
================================================
+ Hits         337817     362537     +24720     
+ Misses       105277      95179     -10098     
- Partials      20860      22005      +1145

Flag	Coverage Δ
integration	`49.2493% <100.0000%> (?)`
unit	`72.2094% <100.0000%> (-0.0056%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.7673% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`61.0573% <ø> (+15.5551%)`	⬆️

Defined2014 · 2024-11-28T05:18:08Z

/run check-issue-triage-complete

Defined2014 · 2024-11-28T05:19:53Z

/retest

tiprow · 2024-11-28T05:20:14Z

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Defined2014 · 2024-11-28T05:20:21Z

/check-issue-triage-complete

ti-chi-bot · 2024-11-28T08:00:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Defined2014,lance6716]
~~pkg/ddl/OWNERS~~ [lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-11-28T08:00:29Z

[LGTM Timeline notifier]

Timeline:

2024-11-28 05:17:54.063950705 +0000 UTC m=+700061.683605221: ☑️ agreed by Defined2014.
2024-11-28 08:00:27.682666483 +0000 UTC m=+709815.302320998: ☑️ agreed by lance6716.

Defined2014 · 2024-11-28T12:38:17Z

/retest

tiprow · 2024-11-28T12:38:38Z

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2024-12-05T13:16:09Z

In response to a cherrypick label: new pull request created to branch release-8.5: #58019.

…#57738) close pingcap#57698

…#58019) close #57698

…_pr=95 * executor: fix a bug that global temporary table send cop request (pingcap#588… * statistics: fix the panic when to async load stats with dropped index … * executor: fix prepared protocol charset (pingcap#58872) (pingcap#58931) * *: Update client-go and verify all read ts (pingcap#58909) * integration test: fix test case "br_pitr" (pingcap#58876) * session: add indexes for `mysql.analyze_jobs` (pingcap#58134) (pingcap#58355) * ddl: fix args count for modify column (pingcap#58855) (pingcap#58858) * planner: correct plan when scan tidb related cluster table with KeepOr… * planner: Fix vector not truncated after CBO (pingcap#58809) (pingcap#58844) * ddl: Fix vector index for high dimensional vectors (pingcap#58717) (pingcap#58835) * ddl: Fix issue with concurrent update getting reverted by BackfillData… * statistics: stats cache set default quota as 20% (pingcap#58013) (pingcap#58817) * executor: change the evaluation order of columns in `Update` and `Inse… * statistics: add recover to protect background task (pingcap#58739) (pingcap#58767) * ttl: fix the infinite waiting for delRateLimiter when `tidb_ttl_delete… * ttl: reduce some warnings logs when locking TTL tasks (pingcap#58306) (pingcap#58783) * ttl: retry the rows when del rate limiter returns error in delWorker (… * ttl: reschedule task to other instances when shrinking worker (pingcap#57703) (pingcap#58778) * ttl: fix the issue that one task losing heartbeat will block other tas… * ttl: fix the issue that the task is not cancelled after transfering ow… * ddl: fix job state overridden when concurrent updates don't overlap in… * ttl: set the job history status to `cancelled` if it's removed in GC a… * ttl: fix the timezone issue and panic in the caller of `getSession` (#… * ddl: fix version syncer doesn't print who hasn't synced on partial syn… * ttl: fix the issue that `DROP TABLE` / `ALTER TABLE` will keep job run… * br/stream: allow pitr to create oversized indices (pingcap#58433) (pingcap#58527) * ttl: set a result for timeout scan task during shrinking scan worker (… * executor: fix time zone issue when querying slow log (pingcap#58455) (pingcap#58577) * table: fix the issue that the default value for `BIT` column is wrong … * statistics: temporarily skip handling errors for DDL events (pingcap#58609) (pingcap#58634) * sessionctx: fix null max value to leading wrong warning (pingcap#57898) (pingcap#57935) * planner: convert cartesian semi join with other nulleq condition to cr… * planner: fix idxMergePartPlans forget to deal with RootTaskConds (pingcap#585… * domain: change some stats log level as WARN (pingcap#58316) (pingcap#58555) * planner: quickly get total count from index/column (pingcap#58365) (pingcap#58431) * planner, expr: eval readonly user var during plan phase (pingcap#54462) (pingcap#58540) * metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTot… * br: refactor test to use wait checkpoint method (pingcap#57612) (pingcap#58498) * executor: reuse chunk in hash join v2 during restoring (pingcap#56936) (pingcap#58018) * executor: fix goroutine leak when exceed quota in hash agg (pingcap#58078) (pingcap#58462) * copr: fix the issue that busy threshold may redirect batch copr to fol… * statistics: skip non-exicted table when to init stats (pingcap#58381) (pingcap#58394) * planner: fix incorrectly using the schema for plan cache (pingcap#57964) (pingcap#58090) * *: use DDL subscriber updating stats meta (pingcap#57872) (pingcap#58387) * planner, runtime_filter: Remove redundant logs whose meaning can be di… * statistics: remove dead code (pingcap#58412) (pingcap#58442) * planner: Use/force to apply prefer range scan (pingcap#56928) (pingcap#58444) * statistics: gc the statistics correctly after drop the database (pingcap#5730… * ddl: Fixed partition interval from DayMinute to just Minute. (pingcap#57738) (pingcap#58019) * executor: Enlarge the timeout for fetching TiFlash system tables (pingcap#579…

mjonss added 2 commits November 26, 2024 14:29

Fixed partition interval from DayMinute to just Minute.

82f0215

Using integration test instead of unit test

957f2d4

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 26, 2024

Defined2014 approved these changes Nov 28, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2024

Defined2014 requested a review from tangenta November 28, 2024 05:17

Defined2014 removed the do-not-merge/needs-triage-completed label Nov 28, 2024

Defined2014 requested a review from lance6716 November 28, 2024 07:54

lance6716 approved these changes Nov 28, 2024

View reviewed changes

ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 28, 2024

ti-chi-bot bot merged commit cc59ab0 into pingcap:master Nov 28, 2024
27 checks passed

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 5, 2024

ti-chi-bot mentioned this pull request Dec 5, 2024

ddl: Fixed partition interval from DayMinute to just Minute. (#57738) #58019

Merged

13 tasks

mjonss added a commit to mjonss/tidb that referenced this pull request Dec 5, 2024

ddl: Fixed partition interval from DayMinute to just Minute. (pingcap…

a5df6d5

…#57738) close pingcap#57698

ti-chi-bot bot pushed a commit that referenced this pull request Dec 19, 2024

ddl: Fixed partition interval from DayMinute to just Minute. (#57738) (…

02bdc2b

…#58019) close #57698

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ddl: Fixed partition interval from DayMinute to just Minute. #57738

ddl: Fixed partition interval from DayMinute to just Minute. #57738

Uh oh!

mjonss commented Nov 26, 2024

Uh oh!

tiprow bot commented Nov 26, 2024

Uh oh!

codecov bot commented Nov 26, 2024 •

edited

Loading

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

tiprow bot commented Nov 28, 2024

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

ti-chi-bot bot commented Nov 28, 2024

Uh oh!

ti-chi-bot bot commented Nov 28, 2024

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

tiprow bot commented Nov 28, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Dec 5, 2024

Uh oh!

Uh oh!

ddl: Fixed partition interval from DayMinute to just Minute. #57738

ddl: Fixed partition interval from DayMinute to just Minute. #57738

Uh oh!

Conversation

mjonss commented Nov 26, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Nov 26, 2024

Uh oh!

codecov bot commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

tiprow bot commented Nov 28, 2024

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

ti-chi-bot bot commented Nov 28, 2024

Uh oh!

ti-chi-bot bot commented Nov 28, 2024

[LGTM Timeline notifier]

Uh oh!

Defined2014 commented Nov 28, 2024

Uh oh!

tiprow bot commented Nov 28, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Dec 5, 2024

Uh oh!

Uh oh!

codecov bot commented Nov 26, 2024 •

edited

Loading