Skip to content

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #58452

What changed and how does it work?

fix time zone issue when querying slow log

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix time zone issue when querying slow log

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2024
Copy link

tiprow bot commented Dec 23, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.7287%. Comparing base (d0ea9e5) to head (1a3b906).
Report is 244 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58455        +/-   ##
================================================
+ Coverage   73.5240%   73.7287%   +0.2046%     
================================================
  Files          1681       1681                
  Lines        463969     468207      +4238     
================================================
+ Hits         341129     345203      +4074     
- Misses       101997     102221       +224     
+ Partials      20843      20783        -60     
Flag Coverage Δ
integration 43.3565% <42.8571%> (?)
unit 72.5622% <100.0000%> (+0.2749%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.0100% <ø> (+0.3190%) ⬆️
parser ∅ <ø> (∅)
br 46.0679% <ø> (+0.2965%) ⬆️

@lcwangchao
Copy link
Collaborator Author

/retest

Copy link

tiprow bot commented Dec 23, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CbcWestwolf,tiancaiamao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 24, 2024
Copy link

ti-chi-bot bot commented Dec 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-24 02:49:46.187453201 +0000 UTC m=+1529976.276255744: ☑️ agreed by tiancaiamao.
  • 2024-12-24 04:13:25.683273464 +0000 UTC m=+1534995.772076002: ☑️ agreed by CbcWestwolf.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit f2db9c4 into pingcap:master Dec 24, 2024
24 checks passed
@lcwangchao lcwangchao deleted the fix_slowlog branch December 24, 2024 06:38
@lcwangchao lcwangchao added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Dec 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58577.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58578.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #58579.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58580.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 27, 2024
@lcwangchao
Copy link
Collaborator Author

/cherry-pick release-8.1

@ti-chi-bot
Copy link
Member

@lcwangchao: new pull request created to branch release-8.1: #58851.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lcwangchao
Copy link
Collaborator Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@lcwangchao: new pull request created to branch release-7.5: #58852.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 10, 2025
@lcwangchao lcwangchao added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 7, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 7, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #59289.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 11, 2025
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 4, 2025
…_pr=95

* executor: fix a bug that global temporary table send cop request (pingcap#588…
* statistics: fix the panic when to async load stats with dropped index …
* executor: fix prepared protocol charset (pingcap#58872) (pingcap#58931)
* *: Update client-go and verify all read ts (pingcap#58909)
* integration test: fix test case "br_pitr" (pingcap#58876)
* session: add indexes for `mysql.analyze_jobs` (pingcap#58134) (pingcap#58355)
* ddl: fix args count for modify column (pingcap#58855) (pingcap#58858)
* planner: correct plan when scan tidb related cluster table with KeepOr…
* planner: Fix vector not truncated after CBO (pingcap#58809) (pingcap#58844)
* ddl: Fix vector index for high dimensional vectors (pingcap#58717) (pingcap#58835)
* ddl: Fix issue with concurrent update getting reverted by BackfillData…
* statistics: stats cache set default quota as 20%  (pingcap#58013) (pingcap#58817)
* executor: change the evaluation order of columns in `Update` and `Inse…
* statistics: add recover to protect background task (pingcap#58739) (pingcap#58767)
* ttl: fix the infinite waiting for delRateLimiter when `tidb_ttl_delete…
* ttl: reduce some warnings logs when locking TTL tasks (pingcap#58306) (pingcap#58783)
* ttl: retry the rows when del rate limiter returns error in delWorker (…
* ttl: reschedule task to other instances when shrinking worker (pingcap#57703) (pingcap#58778)
* ttl: fix the issue that one task losing heartbeat will block other tas…
* ttl: fix the issue that the task is not cancelled after transfering ow…
* ddl: fix job state overridden when concurrent updates don't overlap in…
* ttl: set the job history status to `cancelled` if it's removed in GC a…
* ttl: fix the timezone issue and panic in the caller of `getSession` (#…
* ddl: fix version syncer doesn't print who hasn't synced on partial syn…
* ttl: fix the issue that `DROP TABLE` / `ALTER TABLE` will keep job run…
* br/stream: allow pitr to create oversized indices (pingcap#58433) (pingcap#58527)
* ttl: set a result for timeout scan task during shrinking scan worker (…
* executor: fix time zone issue when querying slow log (pingcap#58455) (pingcap#58577)
* table: fix the issue that the default value for `BIT` column is wrong …
* statistics: temporarily skip handling errors for DDL events (pingcap#58609) (pingcap#58634)
* sessionctx: fix null max value to leading wrong warning (pingcap#57898) (pingcap#57935)
* planner: convert cartesian semi join with other nulleq condition to cr…
* planner: fix idxMergePartPlans forget to deal with RootTaskConds (pingcap#585…
* domain: change some stats log level as WARN (pingcap#58316) (pingcap#58555)
* planner: quickly get total count from index/column (pingcap#58365) (pingcap#58431)
* planner, expr: eval readonly user var during plan phase (pingcap#54462) (pingcap#58540)
* metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTot…
* br: refactor test to use wait checkpoint method (pingcap#57612) (pingcap#58498)
* executor: reuse chunk in hash join v2 during restoring (pingcap#56936) (pingcap#58018)
* executor: fix goroutine leak when exceed quota in hash agg (pingcap#58078) (pingcap#58462)
* copr: fix the issue that busy threshold may redirect batch copr to fol…
* statistics: skip non-exicted table when to init stats (pingcap#58381) (pingcap#58394)
* planner: fix incorrectly using the schema for plan cache (pingcap#57964) (pingcap#58090)
* *: use DDL subscriber updating stats meta (pingcap#57872) (pingcap#58387)
* planner, runtime_filter: Remove redundant logs whose meaning can be di…
* statistics: remove dead code (pingcap#58412) (pingcap#58442)
* planner: Use/force to apply prefer range scan (pingcap#56928) (pingcap#58444)
* statistics: gc the statistics correctly after drop the database (pingcap#5730…
* ddl: Fixed partition interval from DayMinute to just Minute. (pingcap#57738) (pingcap#58019)
* executor: Enlarge the timeout for fetching TiFlash system tables (pingcap#579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get wrong result when querying slow logs after time zone changed
5 participants