session: add indexes for `mysql.analyze_jobs` (#58134) #58355

ti-chi-bot · 2024-12-17T10:06:24Z

This is an automated cherry-pick of #58134

What problem does this PR solve?

Issue Number: close #57996

Problem Summary:

What changed and how does it work?

This PR added two indexes for the mysql.analyze_jobs to speed up queries.

I also bumped the bootstrap version from 239 to 140.

Check List

Tests

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

为 `mysql.analyze_jobs` 添加索引加速查询
Add some indexes to `mysql.analyze_jobs` to speed up queries

Signed-off-by: ti-chi-bot <[email protected]>

Signed-off-by: Rustin170506 <[email protected]>

0xPoe

Thanks!

codecov · 2024-12-20T09:11:36Z

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@678b713). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #58355   +/-   ##
================================================
  Coverage               ?   56.8450%           
================================================
  Files                  ?       1770           
  Lines                  ?     627441           
  Branches               ?          0           
================================================
  Hits                   ?     356669           
  Misses                 ?     246733           
  Partials               ?      24039

Flag	Coverage Δ
integration	`36.6953% <0.0000%> (?)`
unit	`72.6049% <57.1428%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8711% <0.0000%> (?)`
parser	`∅ <0.0000%> (?)`
br	`52.2743% <0.0000%> (?)`

ti-chi-bot · 2024-12-20T09:29:43Z

[LGTM Timeline notifier]

Timeline:

2024-12-20 08:58:59.635942787 +0000 UTC m=+1206529.724745329: ☑️ agreed by Rustin170506.
2024-12-20 09:29:42.414713256 +0000 UTC m=+1208372.503515796: ☑️ agreed by AilinKid.

0xPoe · 2024-12-20T09:33:18Z

/hold

Better to add another check before adding the index.

0xPoe · 2025-01-03T06:54:30Z

/retest

0xPoe · 2025-01-03T08:33:06Z

/retest

0xPoe · 2025-01-09T09:00:20Z

/unhold

/retest

Signed-off-by: Rustin170506 <[email protected]>

0xPoe

Thanks!

0xPoe · 2025-01-10T14:02:36Z

/assign benmeadowcroft

ti-chi-bot · 2025-01-10T14:02:40Z

@Rustin170506: GitHub didn't allow me to assign the following users: benmeadowcroft.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-01-10T14:40:34Z

@Rustin170506: You cannot manually add or delete the cherry pick approval state labels, only I and the tursted members have permission to do so. You can approve it in internal platform.

In response to adding label named cherry-pick-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2025-01-13T03:02:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, benmeadowcroft, Rustin170506, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [AilinKid,Rustin170506,YuJuncen]
~~br/OWNERS~~ [YuJuncen]
~~pkg/session/OWNERS~~ [benmeadowcroft]
~~pkg/statistics/OWNERS~~ [AilinKid,Rustin170506]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…_pr=95 * executor: fix a bug that global temporary table send cop request (pingcap#588… * statistics: fix the panic when to async load stats with dropped index … * executor: fix prepared protocol charset (pingcap#58872) (pingcap#58931) * *: Update client-go and verify all read ts (pingcap#58909) * integration test: fix test case "br_pitr" (pingcap#58876) * session: add indexes for `mysql.analyze_jobs` (pingcap#58134) (pingcap#58355) * ddl: fix args count for modify column (pingcap#58855) (pingcap#58858) * planner: correct plan when scan tidb related cluster table with KeepOr… * planner: Fix vector not truncated after CBO (pingcap#58809) (pingcap#58844) * ddl: Fix vector index for high dimensional vectors (pingcap#58717) (pingcap#58835) * ddl: Fix issue with concurrent update getting reverted by BackfillData… * statistics: stats cache set default quota as 20% (pingcap#58013) (pingcap#58817) * executor: change the evaluation order of columns in `Update` and `Inse… * statistics: add recover to protect background task (pingcap#58739) (pingcap#58767) * ttl: fix the infinite waiting for delRateLimiter when `tidb_ttl_delete… * ttl: reduce some warnings logs when locking TTL tasks (pingcap#58306) (pingcap#58783) * ttl: retry the rows when del rate limiter returns error in delWorker (… * ttl: reschedule task to other instances when shrinking worker (pingcap#57703) (pingcap#58778) * ttl: fix the issue that one task losing heartbeat will block other tas… * ttl: fix the issue that the task is not cancelled after transfering ow… * ddl: fix job state overridden when concurrent updates don't overlap in… * ttl: set the job history status to `cancelled` if it's removed in GC a… * ttl: fix the timezone issue and panic in the caller of `getSession` (#… * ddl: fix version syncer doesn't print who hasn't synced on partial syn… * ttl: fix the issue that `DROP TABLE` / `ALTER TABLE` will keep job run… * br/stream: allow pitr to create oversized indices (pingcap#58433) (pingcap#58527) * ttl: set a result for timeout scan task during shrinking scan worker (… * executor: fix time zone issue when querying slow log (pingcap#58455) (pingcap#58577) * table: fix the issue that the default value for `BIT` column is wrong … * statistics: temporarily skip handling errors for DDL events (pingcap#58609) (pingcap#58634) * sessionctx: fix null max value to leading wrong warning (pingcap#57898) (pingcap#57935) * planner: convert cartesian semi join with other nulleq condition to cr… * planner: fix idxMergePartPlans forget to deal with RootTaskConds (pingcap#585… * domain: change some stats log level as WARN (pingcap#58316) (pingcap#58555) * planner: quickly get total count from index/column (pingcap#58365) (pingcap#58431) * planner, expr: eval readonly user var during plan phase (pingcap#54462) (pingcap#58540) * metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTot… * br: refactor test to use wait checkpoint method (pingcap#57612) (pingcap#58498) * executor: reuse chunk in hash join v2 during restoring (pingcap#56936) (pingcap#58018) * executor: fix goroutine leak when exceed quota in hash agg (pingcap#58078) (pingcap#58462) * copr: fix the issue that busy threshold may redirect batch copr to fol… * statistics: skip non-exicted table when to init stats (pingcap#58381) (pingcap#58394) * planner: fix incorrectly using the schema for plan cache (pingcap#57964) (pingcap#58090) * *: use DDL subscriber updating stats meta (pingcap#57872) (pingcap#58387) * planner, runtime_filter: Remove redundant logs whose meaning can be di… * statistics: remove dead code (pingcap#58412) (pingcap#58442) * planner: Use/force to apply prefer range scan (pingcap#56928) (pingcap#58444) * statistics: gc the statistics correctly after drop the database (pingcap#5730… * ddl: Fixed partition interval from DayMinute to just Minute. (pingcap#57738) (pingcap#58019) * executor: Enlarge the timeout for fetching TiFlash system tables (pingcap#579…

This is an automated cherry-pick of pingcap#58134

ed427bb

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Dec 17, 2024

session: add indexes for mysql.analyze_jobs #58134

Merged

14 tasks

ti-chi-bot assigned 0xPoe Dec 17, 2024

ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved label Dec 17, 2024

0xPoe added 2 commits December 20, 2024 16:52

fix: resolve conflicts

f02023d

Signed-off-by: Rustin170506 <[email protected]>

fix: unset store

d22a5ec

Signed-off-by: Rustin170506 <[email protected]>

0xPoe approved these changes Dec 20, 2024

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 20, 2024

AilinKid approved these changes Dec 20, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024

ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Cherry pick PR approved by release team. labels Jan 9, 2025

fix: update expected count in index usage test

bdf3887

Signed-off-by: Rustin170506 <[email protected]>

0xPoe approved these changes Jan 10, 2025

View reviewed changes

0xPoe requested a review from Leavrth January 10, 2025 14:02

0xPoe added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 10, 2025

ti-chi-bot bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jan 10, 2025

ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved label Jan 10, 2025

benmeadowcroft approved these changes Jan 10, 2025

View reviewed changes

ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 11, 2025

YuJuncen approved these changes Jan 13, 2025

View reviewed changes

ti-chi-bot bot added the approved label Jan 13, 2025

ti-chi-bot bot merged commit f0db14c into pingcap:release-8.5 Jan 13, 2025
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

session: add indexes for `mysql.analyze_jobs` (#58134) #58355

session: add indexes for `mysql.analyze_jobs` (#58134) #58355

Uh oh!

ti-chi-bot commented Dec 17, 2024

Uh oh!

0xPoe left a comment

Uh oh!

codecov bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

ti-chi-bot bot commented Dec 20, 2024

Uh oh!

0xPoe commented Dec 20, 2024

Uh oh!

0xPoe commented Jan 3, 2025

Uh oh!

0xPoe commented Jan 3, 2025

Uh oh!

0xPoe commented Jan 9, 2025

Uh oh!

0xPoe left a comment

Uh oh!

0xPoe commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 13, 2025

Uh oh!

Uh oh!

Uh oh!

session: add indexes for mysql.analyze_jobs (#58134) #58355

session: add indexes for mysql.analyze_jobs (#58134) #58355

Uh oh!

Conversation

ti-chi-bot commented Dec 17, 2024

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

0xPoe left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Uh oh!

0xPoe commented Dec 20, 2024

Uh oh!

0xPoe commented Jan 3, 2025

Uh oh!

0xPoe commented Jan 3, 2025

Uh oh!

0xPoe commented Jan 9, 2025

Uh oh!

0xPoe left a comment

Choose a reason for hiding this comment

Uh oh!

0xPoe commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 10, 2025

Uh oh!

ti-chi-bot bot commented Jan 13, 2025

Uh oh!

Uh oh!

Uh oh!

session: add indexes for `mysql.analyze_jobs` (#58134) #58355

session: add indexes for `mysql.analyze_jobs` (#58134) #58355

codecov bot commented Dec 20, 2024 •

edited

Loading