ttl: reduce some warnings logs when locking TTL tasks #58306

lcwangchao · 2024-12-16T13:25:21Z

What problem does this PR solve?

Issue Number: close #58305

What changed and how does it work?

When rescheduleTasks and found some unlocked tasks, try infoSchemaCache.Update first to make the infoschema upde to date

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

ttl: reduce some warnings logs

tiprow · 2024-12-16T13:25:38Z

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2024-12-16T13:44:19Z

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.8170%. Comparing base (8a80a41) to head (3549342).
Report is 149 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58306        +/-   ##
================================================
+ Coverage   73.2172%   73.8170%   +0.5997%     
================================================
  Files          1679       1679                
  Lines        462451     463954      +1503     
================================================
+ Hits         338594     342477      +3883     
+ Misses       103079     100759      -2320     
+ Partials      20778      20718        -60

Flag	Coverage Δ
integration	`43.3459% <37.5000%> (?)`
unit	`72.5595% <50.0000%> (+0.2039%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`46.0500% <ø> (+0.0390%)`	⬆️

YangKeao

LGTM

bb7133

LGTM

ti-chi-bot · 2024-12-17T07:27:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,bb7133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-12-17T07:27:14Z

[LGTM Timeline notifier]

Timeline:

2024-12-17 02:24:00.10015527 +0000 UTC m=+923630.188957808: ☑️ agreed by YangKeao.
2024-12-17 07:27:13.732302171 +0000 UTC m=+941823.821104725: ☑️ agreed by bb7133.

lcwangchao · 2024-12-17T10:01:16Z

/retest

tiprow · 2024-12-17T10:01:37Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lcwangchao · 2024-12-17T12:53:17Z

/retest

tiprow · 2024-12-17T12:53:39Z

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-01-08T03:58:44Z

In response to a cherrypick label: new pull request created to branch release-8.5: #58783.

Signed-off-by: ti-chi-bot <[email protected]>

close #58305

…_pr=95 * executor: fix a bug that global temporary table send cop request (pingcap#588… * statistics: fix the panic when to async load stats with dropped index … * executor: fix prepared protocol charset (pingcap#58872) (pingcap#58931) * *: Update client-go and verify all read ts (pingcap#58909) * integration test: fix test case "br_pitr" (pingcap#58876) * session: add indexes for `mysql.analyze_jobs` (pingcap#58134) (pingcap#58355) * ddl: fix args count for modify column (pingcap#58855) (pingcap#58858) * planner: correct plan when scan tidb related cluster table with KeepOr… * planner: Fix vector not truncated after CBO (pingcap#58809) (pingcap#58844) * ddl: Fix vector index for high dimensional vectors (pingcap#58717) (pingcap#58835) * ddl: Fix issue with concurrent update getting reverted by BackfillData… * statistics: stats cache set default quota as 20% (pingcap#58013) (pingcap#58817) * executor: change the evaluation order of columns in `Update` and `Inse… * statistics: add recover to protect background task (pingcap#58739) (pingcap#58767) * ttl: fix the infinite waiting for delRateLimiter when `tidb_ttl_delete… * ttl: reduce some warnings logs when locking TTL tasks (pingcap#58306) (pingcap#58783) * ttl: retry the rows when del rate limiter returns error in delWorker (… * ttl: reschedule task to other instances when shrinking worker (pingcap#57703) (pingcap#58778) * ttl: fix the issue that one task losing heartbeat will block other tas… * ttl: fix the issue that the task is not cancelled after transfering ow… * ddl: fix job state overridden when concurrent updates don't overlap in… * ttl: set the job history status to `cancelled` if it's removed in GC a… * ttl: fix the timezone issue and panic in the caller of `getSession` (#… * ddl: fix version syncer doesn't print who hasn't synced on partial syn… * ttl: fix the issue that `DROP TABLE` / `ALTER TABLE` will keep job run… * br/stream: allow pitr to create oversized indices (pingcap#58433) (pingcap#58527) * ttl: set a result for timeout scan task during shrinking scan worker (… * executor: fix time zone issue when querying slow log (pingcap#58455) (pingcap#58577) * table: fix the issue that the default value for `BIT` column is wrong … * statistics: temporarily skip handling errors for DDL events (pingcap#58609) (pingcap#58634) * sessionctx: fix null max value to leading wrong warning (pingcap#57898) (pingcap#57935) * planner: convert cartesian semi join with other nulleq condition to cr… * planner: fix idxMergePartPlans forget to deal with RootTaskConds (pingcap#585… * domain: change some stats log level as WARN (pingcap#58316) (pingcap#58555) * planner: quickly get total count from index/column (pingcap#58365) (pingcap#58431) * planner, expr: eval readonly user var during plan phase (pingcap#54462) (pingcap#58540) * metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTot… * br: refactor test to use wait checkpoint method (pingcap#57612) (pingcap#58498) * executor: reuse chunk in hash join v2 during restoring (pingcap#56936) (pingcap#58018) * executor: fix goroutine leak when exceed quota in hash agg (pingcap#58078) (pingcap#58462) * copr: fix the issue that busy threshold may redirect batch copr to fol… * statistics: skip non-exicted table when to init stats (pingcap#58381) (pingcap#58394) * planner: fix incorrectly using the schema for plan cache (pingcap#57964) (pingcap#58090) * *: use DDL subscriber updating stats meta (pingcap#57872) (pingcap#58387) * planner, runtime_filter: Remove redundant logs whose meaning can be di… * statistics: remove dead code (pingcap#58412) (pingcap#58442) * planner: Use/force to apply prefer range scan (pingcap#56928) (pingcap#58444) * statistics: gc the statistics correctly after drop the database (pingcap#5730… * ddl: Fixed partition interval from DayMinute to just Minute. (pingcap#57738) (pingcap#58019) * executor: Enlarge the timeout for fetching TiFlash system tables (pingcap#579…

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2024

ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 16, 2024

lcwangchao requested a review from YangKeao December 16, 2024 13:47

YangKeao approved these changes Dec 17, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024

bb7133 approved these changes Dec 17, 2024

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024

lcwangchao added 2 commits December 17, 2024 18:12

ttl: reduce some warnings logs when locking TTL tasks

221528d

Merge branch 'master' into fix_58305

3549342

lcwangchao force-pushed the fix_58305 branch from 9590f41 to 3549342 Compare December 17, 2024 10:13

ti-chi-bot bot merged commit d92dce0 into pingcap:master Dec 17, 2024
22 checks passed

lcwangchao deleted the fix_58305 branch December 17, 2024 13:30

lcwangchao added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 8, 2025

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 8, 2025

This is an automated cherry-pick of pingcap#58306

4fac6e1

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jan 8, 2025

ttl: reduce some warnings logs when locking TTL tasks (#58306) #58783

Merged

13 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Jan 8, 2025

ttl: reduce some warnings logs when locking TTL tasks (#58306) (#58783)

1f11785

close #58305

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ttl: reduce some warnings logs when locking TTL tasks #58306

ttl: reduce some warnings logs when locking TTL tasks #58306

Uh oh!

lcwangchao commented Dec 16, 2024 •

edited

Loading

Uh oh!

tiprow bot commented Dec 16, 2024

Uh oh!

codecov bot commented Dec 16, 2024 •

edited

Loading

Uh oh!

YangKeao left a comment

Uh oh!

bb7133 left a comment

Uh oh!

ti-chi-bot bot commented Dec 17, 2024

Uh oh!

ti-chi-bot bot commented Dec 17, 2024

Uh oh!

lcwangchao commented Dec 17, 2024

Uh oh!

tiprow bot commented Dec 17, 2024

Uh oh!

lcwangchao commented Dec 17, 2024

Uh oh!

tiprow bot commented Dec 17, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Jan 8, 2025

Uh oh!

Uh oh!

ttl: reduce some warnings logs when locking TTL tasks #58306

ttl: reduce some warnings logs when locking TTL tasks #58306

Uh oh!

Conversation

lcwangchao commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Dec 16, 2024

Uh oh!

codecov bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

YangKeao left a comment

Choose a reason for hiding this comment

Uh oh!

bb7133 left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Dec 17, 2024

Uh oh!

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Uh oh!

lcwangchao commented Dec 17, 2024

Uh oh!

tiprow bot commented Dec 17, 2024

Uh oh!

lcwangchao commented Dec 17, 2024

Uh oh!

tiprow bot commented Dec 17, 2024

Uh oh!

Uh oh!

ti-chi-bot commented Jan 8, 2025

Uh oh!

Uh oh!

lcwangchao commented Dec 16, 2024 •

edited

Loading

codecov bot commented Dec 16, 2024 •

edited

Loading