Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57964

What problem does this PR solve?

Issue Number: close #56733

Problem Summary:
If the table ID is changed for a given table name, the plan cache key is not updated.
For an insert statement, it may use the outdated schema, resulting in incorrect data or query results.

What changed and how does it work?

Make sure the tbl is updated in function planCachePreprocess() if tableByID doesn't return the table info.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix incorrectly using the schema for plan cache

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 9, 2024
Copy link

ti-chi-bot bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qw4990, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 9, 2024
Copy link

ti-chi-bot bot commented Dec 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-09 11:19:31.48287976 +0000 UTC m=+264561.571682298: ☑️ agreed by tangenta.
  • 2024-12-09 12:17:45.666770029 +0000 UTC m=+268055.755572568: ☑️ agreed by qw4990.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@9db025d). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #58090   +/-   ##
================================================
  Coverage               ?   57.1328%           
================================================
  Files                  ?       1773           
  Lines                  ?     629183           
  Branches               ?          0           
================================================
  Hits                   ?     359470           
  Misses                 ?     245576           
  Partials               ?      24137           
Flag Coverage Δ
integration 37.1135% <50.0000%> (?)
unit 72.7856% <50.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8711% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.5070% <0.0000%> (?)

@wuhuizuo
Copy link
Contributor

/test all

Copy link

tiprow bot commented Dec 23, 2024

@wuhuizuo: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 6f9db8d into pingcap:release-8.5 Dec 23, 2024
18 of 19 checks passed
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Jan 6, 2025
crazycs520 pushed a commit to crazycs520/tidb that referenced this pull request Jun 4, 2025
…_pr=95

* executor: fix a bug that global temporary table send cop request (pingcap#588…
* statistics: fix the panic when to async load stats with dropped index …
* executor: fix prepared protocol charset (pingcap#58872) (pingcap#58931)
* *: Update client-go and verify all read ts (pingcap#58909)
* integration test: fix test case "br_pitr" (pingcap#58876)
* session: add indexes for `mysql.analyze_jobs` (pingcap#58134) (pingcap#58355)
* ddl: fix args count for modify column (pingcap#58855) (pingcap#58858)
* planner: correct plan when scan tidb related cluster table with KeepOr…
* planner: Fix vector not truncated after CBO (pingcap#58809) (pingcap#58844)
* ddl: Fix vector index for high dimensional vectors (pingcap#58717) (pingcap#58835)
* ddl: Fix issue with concurrent update getting reverted by BackfillData…
* statistics: stats cache set default quota as 20%  (pingcap#58013) (pingcap#58817)
* executor: change the evaluation order of columns in `Update` and `Inse…
* statistics: add recover to protect background task (pingcap#58739) (pingcap#58767)
* ttl: fix the infinite waiting for delRateLimiter when `tidb_ttl_delete…
* ttl: reduce some warnings logs when locking TTL tasks (pingcap#58306) (pingcap#58783)
* ttl: retry the rows when del rate limiter returns error in delWorker (…
* ttl: reschedule task to other instances when shrinking worker (pingcap#57703) (pingcap#58778)
* ttl: fix the issue that one task losing heartbeat will block other tas…
* ttl: fix the issue that the task is not cancelled after transfering ow…
* ddl: fix job state overridden when concurrent updates don't overlap in…
* ttl: set the job history status to `cancelled` if it's removed in GC a…
* ttl: fix the timezone issue and panic in the caller of `getSession` (#…
* ddl: fix version syncer doesn't print who hasn't synced on partial syn…
* ttl: fix the issue that `DROP TABLE` / `ALTER TABLE` will keep job run…
* br/stream: allow pitr to create oversized indices (pingcap#58433) (pingcap#58527)
* ttl: set a result for timeout scan task during shrinking scan worker (…
* executor: fix time zone issue when querying slow log (pingcap#58455) (pingcap#58577)
* table: fix the issue that the default value for `BIT` column is wrong …
* statistics: temporarily skip handling errors for DDL events (pingcap#58609) (pingcap#58634)
* sessionctx: fix null max value to leading wrong warning (pingcap#57898) (pingcap#57935)
* planner: convert cartesian semi join with other nulleq condition to cr…
* planner: fix idxMergePartPlans forget to deal with RootTaskConds (pingcap#585…
* domain: change some stats log level as WARN (pingcap#58316) (pingcap#58555)
* planner: quickly get total count from index/column (pingcap#58365) (pingcap#58431)
* planner, expr: eval readonly user var during plan phase (pingcap#54462) (pingcap#58540)
* metrics: add col/idx name(s) for BackfillProgressGauge and BackfillTot…
* br: refactor test to use wait checkpoint method (pingcap#57612) (pingcap#58498)
* executor: reuse chunk in hash join v2 during restoring (pingcap#56936) (pingcap#58018)
* executor: fix goroutine leak when exceed quota in hash agg (pingcap#58078) (pingcap#58462)
* copr: fix the issue that busy threshold may redirect batch copr to fol…
* statistics: skip non-exicted table when to init stats (pingcap#58381) (pingcap#58394)
* planner: fix incorrectly using the schema for plan cache (pingcap#57964) (pingcap#58090)
* *: use DDL subscriber updating stats meta (pingcap#57872) (pingcap#58387)
* planner, runtime_filter: Remove redundant logs whose meaning can be di…
* statistics: remove dead code (pingcap#58412) (pingcap#58442)
* planner: Use/force to apply prefer range scan (pingcap#56928) (pingcap#58444)
* statistics: gc the statistics correctly after drop the database (pingcap#5730…
* ddl: Fixed partition interval from DayMinute to just Minute. (pingcap#57738) (pingcap#58019)
* executor: Enlarge the timeout for fetching TiFlash system tables (pingcap#579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants